Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing box vectors from 2.3 #182

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Dec 4, 2024

resolves #181

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Dec 4, 2024

Binder 👈 Launch a binder notebook on branch OpenFreeEnergy/ExampleNotebooks/181-showcase-notebook-incorrectly-says-we-can-set-box-dimensions-via-the-chemicalsystem

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open a separate issue to add details about solvation @atravitz ?

@atravitz
Copy link
Contributor Author

atravitz commented Dec 4, 2024

Could you open a separate issue to add details about solvation @atravitz ?

#183 done!

@atravitz atravitz merged commit cf41975 into main Dec 4, 2024
5 checks passed
@atravitz atravitz deleted the 181-showcase-notebook-incorrectly-says-we-can-set-box-dimensions-via-the-chemicalsystem branch December 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showcase notebook incorrectly says we can set box dimensions via the ChemicalSystem
2 participants